feat: add universal2 support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
commented
Jul 18, 2021
Comment on lines
+14
to
+15
| "CFLAGS": "-save-temps", | ||
| "CXXFLAGS": "-save-temps", |
There was a problem hiding this comment.
Not sure why this is required when building locally but not in GHA...
It definitely fails without this on my laptop.
mayeut
commented
Jul 18, 2021
| @@ -19,6 +19,7 @@ manylinux-i686-image = "manylinux1" | |||
|
|
|||
| [tool.cibuildwheel.macos.environment] | |||
| MACOSX_DEPLOYMENT_TARGET = "10.9" | |||
| CMAKE_OSX_ARCHITECTURES = "arm64;x86_64" | |||
There was a problem hiding this comment.
We should be able to get rid of this once scikit-build 0.12 lands.
mayeut
force-pushed
the
universal2
branch
2 times, most recently
from
ffb0ebb
to
e2445c2
Compare
|
I'll push one for Ninja |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35 & #41
Depends on #61 & #62