docs: improve ninja.make-fallback description in the README #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henryiii I presume this is the right description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 64 64
Lines 3315 3315
=======================================
Hits 2861 2861
Misses 454 454 ☔ View full report in Codecov by Sentry. |
thewtex
force-pushed
the
ninja-make-fallback-description
branch
from
5d53569
to
69d36ca
Compare
|
This comes from |
thewtex
force-pushed
the
ninja-make-fallback-description
branch
2 times, most recently
from
18f8ec9
to
399d58d
Compare
thewtex
force-pushed
the
ninja-make-fallback-description
branch
from
399d58d
to
76c4b67
Compare
henryiii
approved these changes
Mar 29, 2024
henryiii
added a commit
that referenced
this pull request
Apr 2, 2024
Fix #676. None was being replaced by `false`. Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.