Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix install strip default #681

Merged
merged 1 commit into from Apr 2, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

Fix #676.

None was being replaced by false.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.30%. Comparing base (3594f33) to head (cf0d727).
Report is 4 commits behind head on main.

Files Patch % Lines
src/scikit_build_core/settings/skbuild_docs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   86.30%   86.30%           
=======================================
  Files          64       64           
  Lines        3314     3315    +1     
=======================================
+ Hits         2860     2861    +1     
  Misses        454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 32a1c5d into main Apr 2, 2024
47 of 53 checks passed
@henryiii henryiii deleted the henryiii/docs/installstrip branch April 2, 2024 22:52
@thewtex
Copy link
Member

thewtex commented Apr 3, 2024

@henryiii thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants