Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error checking associated with cmake_source_dir skbuild.setup keyword #169

Closed
2 tasks done
jcfr opened this issue Sep 11, 2016 · 2 comments
Closed
2 tasks done
Labels
Type: Enhancement Improvement to functionality Type: Question User question

Comments

@jcfr
Copy link
Contributor

jcfr commented Sep 11, 2016

This is related to the feature introduced in #168

  • Raise an exception (or warning ?) if cmake_source_dir points to directory outside of the project source tree.
  • When cmake_source_dir points to a sub directory with a CMakeLists.txt and there is already one in the top-level, report a warning indicating that the top-level one will be ignored.
@jcfr jcfr added Type: Enhancement Improvement to functionality Type: Question User question labels Sep 11, 2016
@jcfr
Copy link
Contributor Author

jcfr commented Jul 29, 2018

Raise an exception (or warning ?) if cmake_source_dir points to directory outside of the project source tree.

This is now supported since 5e52d5c fixing issue #335

@jcfr
Copy link
Contributor Author

jcfr commented Jul 29, 2018

When cmake_source_dir points to a sub directory with a CMakeLists.txt and there is already one in the top-level, report a warning indicating that the top-level one will be ignored.

I don't think scikit-build should try to be too smart, for complex project is is reasonable to have such a situation.

@jcfr jcfr closed this as completed Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement to functionality Type: Question User question
Projects
None yet
Development

No branches or pull requests

1 participant