Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing of scikit-build sample projects #63

Open
1 of 2 tasks
jcfr opened this issue Jul 17, 2016 · 2 comments
Open
1 of 2 tasks

Refactor testing of scikit-build sample projects #63

jcfr opened this issue Jul 17, 2016 · 2 comments
Assignees
@jcfr
Labels
Category: Tests Testing and related things Type: Refactor Refactoring code

Comments

@jcfr
Copy link
Contributor

jcfr commented Jul 17, 2016 •
edited

Currently ctest is invoked to run test of each sample projects and we should also avoid explicitly setting PYTHONPATH. Mocking with PYTHONPATH is causing problem with tools like a tox (e.g #62)

Instead, sample project level tests:

  • should be implemented as regular python test using either node or python unittest.
  • sample project tests should be executed in two contexts:
    • developer mode / editable package mode
    • installed package mode
jcfr pushed a commit that referenced this issue Jul 17, 2016
@thewtex
Fixes towards a passing tox run
c11dc6d 
Other tests need similar fixes and #63 needs to be addressed.
@jcfr
Copy link
Contributor Author

jcfr commented Jul 17, 2016

xref #42

@jcfr jcfr added the Type: Enhancement Improvement to functionality label Jul 18, 2016
@jcfr jcfr self-assigned this Jul 18, 2016
@jcfr jcfr mentioned this issue Jul 20, 2016
Merged
@opadron opadron mentioned this issue Jul 21, 2016
Closed
jcfr added a commit that referenced this issue Jul 22, 2016
@opadron @jcfr
Refactor tests introducing reusable decorators. See #63, #78
88239c6 
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
jcfr added a commit that referenced this issue Jul 22, 2016
@jcfr
Merge branch 'setuptools-topic-reorganized' into fix-master
62e41b4 
* setuptools-topic-reorganized:
  Refactor tests introducing reusable decorators. See #63, #78
  style: Rename distutils_wrap to setuptools_wrap
  Introduce bdist and bdist_wheel command. Fixes #84, Fixes #85
  Add setuptools dependency. Fixes #68
  cmaker: Reintroduce exceptions when using sysconfig
  style: Simplify distutils_wrap removing intermediate var
  style: Fix indent in cmaker
jcfr added a commit that referenced this issue Jul 22, 2016
@jcfr
Merge branch 'setuptools-topic-reorganized' into master-reorganized
dc2091b 
* setuptools-topic-reorganized:
  Refactor tests introducing reusable decorators. See #63, #78
  style: Rename distutils_wrap to setuptools_wrap
  Introduce bdist and bdist_wheel command. Fixes #84, Fixes #85
  Add setuptools dependency. Fixes #68
  cmaker: Reintroduce exceptions when using sysconfig
  style: Simplify distutils_wrap removing intermediate var
  style: Fix indent in cmaker
jcfr added a commit that referenced this issue Jul 22, 2016
@jcfr
Simplify tests implementing decorator function. See #63
b8874d6 
This commit simplifies the test infrastructure by:
* adding 'six' as a requirements
* implementing 'project_setup_py_test' instead of a class of the same name
* excluding 'project_setup_py_test' from test in setup.cfg
@jcfr
Copy link
Contributor Author

jcfr commented Sep 2, 2016

As a side note, tox works great:

$ tox
[...]
  py27: commands succeeded
ERROR:   py33: InterpreterNotFound: python3.3
  py34: commands succeeded
  py35: commands succeeded

@jcfr jcfr added Category: Tests Testing and related things Type: Refactor Refactoring code and removed Type: Enhancement Improvement to functionality labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
Category: Tests Testing and related things Type: Refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfr