Switch to setuptools #89
Conversation
|
This should fix #85 |
|
❌ Build scikit-build 0.0.1.323 failed (commit 98b62a946f by @opadron) |
|
❌ Build scikit-build 0.0.1.324 failed (commit f582dfa071 by @opadron) |
|
woot! LGTM, but CI is not yet passing |
|
✅ Build scikit-build 0.0.1.325 completed (commit 6b169d3a68 by @opadron) |
|
✅ Build scikit-build 0.0.1.326 completed (commit 173a48489a by @opadron) |
|
✅ Build scikit-build 0.0.1.327 completed (commit ee7a1a71f8 by @opadron) |
|
@thewtex could you take another pass at this? I've added some more changes to get CI working. |
| cwd = os.getcwd() | ||
| cmd = ['cmake', cwd, '-G', generator_id] | ||
| cmd.extend( | ||
| "=".join((cmake_variable, value)) for cmake_variable, value in ( |
There was a problem hiding this comment.
Could we simply extend the list, I don't think using the join and for loop give us much here ?
There was a problem hiding this comment.
Different strokes, I guess. I had hoped this would make the arguments that we're passing easier to read through.
|
xref #63 (Refactor testing of scikit-build sample projects) |
|
✅ Build scikit-build 0.0.1.364 completed (commit 60d00aa458 by @opadron) |
|
✅ Build scikit-build 0.0.1.365 completed (commit 5c2920ff2b by @opadron) |
|
@scikit-build/developers PTAL |
|
👍 |
|
Wheel builders, rejoice! 🎉 |
|
It turns out that this topic broke the submission of instead of |
|
It turns out that the test |
Building wheels should now work!
Also refactors some of the test code. Subproject tests (defined in their
CMakeLists.txtfiles) are currently commented out. They will later be replaced with nose-friendly versions.