Improve detection of python library path #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea about the one failure? |
No, clue. It does not make sense to me. I can spend some more time tomorrow, if you are interested in this PR. |
|
Thanks, I would hope it would enable #624. |
|
I'll debug it and come back to you. |
This patch considers the LIBDIR variable from both `distutils.sysconfig` and `sysconfig`. This is necessary to correctly detect the python library path when using pypy with recent setuputils versions.
|
I found the problem. I overlooked one case. Now it is working as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch considers the LIBDIR variable from both
distutils.sysconfigandsysconfig. This is necessary to correctly detect the python library path when using pypy with recent setuputils versions. (See #618.)