Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect python library on macos + pypy #630

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Detect python library on macos + pypy #630

merged 1 commit into from
Jan 24, 2022

Conversation

rkaminsk
Copy link
Contributor

This improves on #624 reenabling the test for the python library which is found correctly now. I did not know how to fix the inplace build test, though.

@henryiii henryiii merged commit 1d6e191 into scikit-build:master Jan 24, 2022
@henryiii
Copy link
Contributor

Thanks! In place builds are borderline broken already, so a little extra issue there isn't too bad at the moment. We need to fix rebuilding in PEP 517 probably first - which means adding PEP 517 tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants