fix: ensure Exception if branch evaluates for Awkward type #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, let me retry this. |
agoose77
force-pushed
the
agoose77/fix-ensure-error-awkward
branch
from
810db76
to
5b53d6b
Compare
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Jan 13, 2023
…that you can't get there, much like a value assertion with the `assert` statement.)
jpivarski
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
type_to_formshould never be called on an Awkward type infrom_rdataframe, but we should probably handle that case anyway to make the code more readable.