-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve kernel error handling logic (1 of 3) #2505
Conversation
c2db368
to
2b8ca64
Compare
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much-needed refactoring. The kernel-error handling was getting pretty crusty.
Although it touches a lot of files, most of them are just swapping names (and making the error-handling call "selfless"). It looks straightforward enough to me that I can just merge it.
For a while I've been intending upon refactoring the error handling logic for kernels, so that it's not associated with
Content
.This PR does two things:
_selfless_handle_error
fromContent
toBackend.maybe_kernel_error
_handle_error
and renames toContent._maybe_index_error
(name TBD)