chore: move C++ format configuration #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Jul 3, 2023
header-only/CMakeLists.txt
Outdated
Comment on lines
1
to
2
| # BSD 3-Clause License; see | ||
| # https://github.com/scikit-hep/awkward-1.0/blob/main/LICENSE |
There was a problem hiding this comment.
I don't like the license being multi-line, even if it is a long line, but it looks like this is happening exactly once, in CMakeLists only (instead of every single C++ file). That's fine.
Actually, I'll try to see if it fits with 4 fewer characters.
Suggested change
| # BSD 3-Clause License; see | |
| # https://github.com/scikit-hep/awkward-1.0/blob/main/LICENSE | |
| # BSD 3-Clause License; see https://github.com/scikit-hep/awkward/blob/main/LICENSE |
|
Taking your "it's fine" as tacit approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2553 will also require a C++ release, so this PR can go in at the same time.