-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make C++ LayoutBuilder API consistent with the Numba's #2553
Conversation
Codecov Report
Additional details and impacted files |
@agoose77 - Could you, please, have a look? I don't understand why the docs are not built. I see lots of warnings, but it doesn't look like they are related to this PR: https://github.com/scikit-hep/awkward/actions/runs/5423275687/jobs/9861495154 Am I wrong? Thanks! |
@ianna the latest build reported in the PR seem to have succeeded? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recognize all of these API changes; looks good!
The C++ test has been updated—I was going to complain about tests that remove functionality that we still have, like test_List
, but then realized that we retained lb::ListOffset
and not lb::List
. So the tests look good, too, now that I've corrected myself.
The changes to lb::Record
will likely impact @ManasviGoyal's work, so she'll have to update to Awkward 2.3 soon after it gets released (maybe tomorrow).
@ianna, you can merge when ready.
Oh, I think, I broke the main build - I got a message that it needs a new C++ release :-( |
@ianna that's OK - we anticipated it, and C++ releases conveniently can be done ahead of the Python release in an async fashion. |
* fix: make the examples consistent with the changes in #2553 * fix: update AWKWARD_VERSION too! * (amend) * fix: clarify that numpy is required * refactor: use `find_package(Python, ...` --------- Co-authored-by: Angus Hollands <goosey15@gmail.com>
LayoutBuilder in C++ and Numba should have the same API, as discussed here: #2408 (comment) by @jpivarski: