Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add touch_data to ak.typetracer #2672

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Aug 25, 2023

This was requested in #2668, and I've identified that Coffea and dask-awkward currently use our private APIs. We should just make this public.

At this stage, I'd prefer to expose this via ak.typetracer, rather than Content.touch_data, as we can better control the public API (e.g. always recursive, return self), and most people are already working with ak.Array objects.

Closes #2668

@agoose77 agoose77 temporarily deployed to docs-preview August 25, 2023 09:09 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2672 (0c3411c) into main (6de30f1) will increase coverage by 0.00%.
The diff coverage is 94.73%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/_do.py 83.43% <75.00%> (-0.22%) ⬇️
src/awkward/typetracer.py 94.28% <100.00%> (+1.18%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I think that Coffea was also using _touch_data temporarily, waiting for some version of it to become public, right @lgray? If so, then this will also serve that purpose.

@lgray
Copy link
Contributor

lgray commented Aug 25, 2023

Yes - there are a few places where we still call _touch_data though length_zero_if_typetracer got rid of most of them.

@agoose77 agoose77 merged commit 3cd54fa into main Aug 25, 2023
35 checks passed
@agoose77 agoose77 deleted the agoose77/feat-add-touch-data-typetracer branch August 25, 2023 13:52
@danielballan
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can _touch_data be made public?
4 participants