Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Numpy 2.0 out of bounds error for BitMaskedArray Py kernels #3073

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: Numpy 2.0 out of bounds error for BitMaskedArray Py kernels #3073

merged 1 commit into from
Apr 4, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Apr 4, 2024 •
edited

jpivarski
jpivarski approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We talked about it in our Awkward-Uproot meeting. Also, having more tests that before is even better.

This is now mergeable, and it looks clear to me that the PR is done (you don't have any more edits), so I'll just merge it. Thanks!

kernel-specification.yml Show resolved Hide resolved
@jpivarski jpivarski merged commit 2d7d610 into main Apr 4, 2024
42 of 43 checks passed
@jpivarski jpivarski deleted the ManasviGoyal/fix-3071-BitMaskedArray-out-of-bounds branch April 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy 2.x causes out of bounds error for BitMaskedArray kernels
2 participants
@ManasviGoyal @jpivarski