Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options for "NaN" strings as NaN floats #568

Merged
merged 7 commits into from
Dec 3, 2020

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Dec 3, 2020

Address Issue #437

Note, it replaces #543 by moving ianna/handle_stream_of_many_JSON_files to a new branch.

@ianna
Copy link
Collaborator Author

ianna commented Dec 3, 2020

@jpivarski - FYI, the PR should be complete if the tests pass.

@jpivarski
Copy link
Member

@ianna Thanks! Don't worry about the job failures—I'm going to fix them (and a few odds and ends) because I want to get down to zero pull requests to do a mastermain renaming.

@jpivarski jpivarski merged commit 70b415d into master Dec 3, 2020
@jpivarski jpivarski deleted the ianna/handle_stream_of_many_JSON_files-v2 branch December 3, 2020 22:26
@ianna
Copy link
Collaborator Author

ianna commented Dec 4, 2020

Thanks @jpivarski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants