Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable POI for significance #365

Merged
merged 2 commits into from
Sep 10, 2022

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Sep 7, 2022

This is an extension of #348 to also support poi_name in fit.significance. This allows to specify the parameter for which the significance calculation is performed.

The implementation follows #364, and as such also requires at least the pyhf RC 4 for v0.7 that was added there.

* added ability to set POI via poi_name keyword argument in fit.significance

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6a96853) compared to base (0a92ee0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2013      2019    +6     
  Branches       330       331    +1     
=========================================
+ Hits          2013      2019    +6     
Impacted Files Coverage Δ
src/cabinetry/fit/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held merged commit f0f9593 into master Sep 10, 2022
@alexander-held alexander-held deleted the feat/significance-poi-name branch September 10, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant