Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make POI optional in config and allow POI customization for inference #348

Merged
merged 8 commits into from
Jul 30, 2022

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Jul 30, 2022

The changes in scikit-hep/pyhf#1638 and scikit-hep/pyhf#1636 made POIs in pyhf workspaces optional. This means they can also be optional for the cabinetry config when building models. If not specified, the POI defaults to "" which is interpreted as "no POI" by pyhf.

A new keyword argument poi_name was added to fit.ranking and fit.limit to override the POI given in the model config.

Also fixing a deprecation warning observed in a test.

resolves #347

* POI is now an optional configuration argument
* added ability to set POI via poi_name keyword arguments in fit.ranking and fit.limit
* fixed pytest deprecation warning in a test

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #348 (c08ee0e) into master (a237589) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1876      1902   +26     
  Branches       298       303    +5     
=========================================
+ Hits          1876      1902   +26     
Impacted Files Coverage Δ
src/cabinetry/fit/__init__.py 100.00% <100.00%> (ø)
src/cabinetry/model_utils.py 100.00% <100.00%> (ø)
src/cabinetry/workspace.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a237589...c08ee0e. Read the comment docs.

@alexander-held alexander-held changed the title feat: make POI config argument optional feat: make POI optional in config and add multi-POI support Jul 30, 2022
@alexander-held alexander-held changed the title feat: make POI optional in config and add multi-POI support feat: make POI optional in config and allow POI customization for inference Jul 30, 2022
@alexander-held alexander-held merged commit 0c75aad into master Jul 30, 2022
@alexander-held alexander-held deleted the feat/poi-config-optional branch July 30, 2022 21:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make POI config argument optional for building POI-less workspaces
1 participant