-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Use find_namespace:
to ensure discovery of package data
#1881
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1881 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 68 68
Lines 4322 4322
Branches 726 726
=======================================
Hits 4243 4243
Misses 46 46
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Given you use a |
Thanks @henryiii! |
Description
Resolves #1880
Use
find_namespace:
in conjunction withinclude_package_data = True
insetup.cfg
to properly find package data (pyhf.data
andpyhf.schemas
) during build of sdist and wheel. The recommendation fromsetuptools
is to treat thedata/
andschemas/
subdirectories as namespace packages given PEP 420.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: