-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use string literal types of generic builtins for type checking #1942
Conversation
I didn't do a good job of describing the details in the PR body, so we should make this more clear before merging and rename the PR to something more correct. |
Codecov Report
@@ Coverage Diff @@
## master #1942 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 69 69
Lines 4439 4439
Branches 748 748
=======================================
Hits 4362 4362
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Use the string form of type checking until Python 3.7 is dropped to avoid having to check for `if typing.TYPE_CHECKING`.
* Revert PR 1937
0352d0d
to
9b52d3d
Compare
* Add typehints to the NumPy backend. * Add .coveragerc file with configuration to ignore pyhf/typing.py. - ref: https://coverage.readthedocs.io/en/6.4.3/excluding.html#advanced-exclusion - Reverts part of PR #1942. * Ignore pyhf/typing.py in Codecov.
Description
Resolves #1941
if typing.TYPE_CHECKING
..coveragerc
as no longer needed.Thanks @henryiii for the nudge on this.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: