Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove sphinx-togglebutton from 'docs' extra #2190

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Apr 30, 2023

Description

Remove sphinx-togglebutton dependency from the 'docs' extra as sphinx-togglebutton was used only to make a instructional admonition into a toggleable dropdown. The admonition was removed in PR #2187 and so sphinx-togglebutton is no longer needed.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove sphinx-togglebutton dependency from the 'docs' extra as
  sphinx-togglebutton was used only to make a instructional admonition
  into a toggleable dropdown. The admonition was removed in PR #2187 and so
  sphinx-togglebutton is no longer needed.
* Remove use of sphinx_togglebutton extension from docs/conf.py.
* Amends PR https://github.com/scikit-hep/pyhf/pull/2187.

* Remove sphinx-togglebutton dependency from the 'docs' extra as
  sphinx-togglebutton was used only to make a instructional admonition
  into a toggleable dropdown. The admonition was removed in PR 2187 and so
  sphinx-togglebutton is no longer needed.
@matthewfeickert matthewfeickert added docs Documentation related build Changes that affect the build system or external dependencies need-to-backport tmp label until can be backported to patch release branch labels Apr 30, 2023
@matthewfeickert matthewfeickert self-assigned this Apr 30, 2023
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b8e942a) 98.30% compared to head (986bf6a) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2190   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4533     4533           
  Branches      801      801           
=======================================
  Hits         4456     4456           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.12% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 0cac458 into main Apr 30, 2023
@matthewfeickert matthewfeickert deleted the build/remove-sphinx-togglebutton branch April 30, 2023 06:26
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 16, 2023
matthewfeickert added a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies docs Documentation related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant