Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Guard Minuit optimizer against provided strategy of None #2278

Merged
merged 9 commits into from
Aug 16, 2023

Apply Alex's readability comment

6cd5366
Select commit
Loading
Failed to load commit list.
Merged

fix: Guard Minuit optimizer against provided strategy of None #2278

Apply Alex's readability comment
6cd5366
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2023 in 0s

98.30% (+0.00%) compared to b81d903

View this Pull Request on Codecov

98.30% (+0.00%) compared to b81d903

Details

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b81d903) 98.30% compared to head (6cd5366) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2278   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4534     4536    +2     
  Branches      801      802    +1     
=======================================
+ Hits         4457     4459    +2     
  Misses         45       45           
  Partials       32       32           
Files Changed Coverage Δ
src/pyhf/optimize/opt_minuit.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.