Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backport): Test xml.etree.ElementTree.Element truth value by 'is not None' #2499

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(backport): Test xml.etree.ElementTree.Element truth value by 'is not None' #2499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyhf/writexml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _export_root_histogram(hist_name, data):
# https://stackoverflow.com/a/4590052
def indent(elem, level=0):
i = "\n" + level * " "
if elem:
if elem is not None:
if not elem.text or not elem.text.strip():
elem.text = i + " "
if not elem.tail or not elem.tail.strip():
Expand Down
2 changes: 1 addition & 1 deletion tests/test_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ def test_integer_data(datadir, mocker):
mocker.patch("pyhf.writexml._ROOT_DATA_FILE")

channel = pyhf.writexml.build_channel(spec, channel_spec, {})
assert channel
assert channel is not None


@pytest.mark.parametrize(
Expand Down
Loading