Require PyTorch v1.0 or newer and fix static TLS load error #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
matthewfeickert
force-pushed
the
fix/pytorch-static-TLS-load-error
branch
from
f363825
to
e49c455
Compare
matthewfeickert
changed the title
|
This PR should wait for PR #381 to be approved and merged and then should be rebased against |
matthewfeickert
force-pushed
the
fix/pytorch-static-TLS-load-error
branch
from
e49c455
to
089a776
Compare
Closed
3 tasks
matthewfeickert
force-pushed
the
fix/pytorch-static-TLS-load-error
branch
from
089a776
to
c3dd459
Compare
kratsg
approved these changes
Jan 10, 2019
In requiring the latest version of PyTorch (v1.0) the loading of it
after other imports in tests/conftest.py causes there to be an error
during setup of the pytest fixtures
ImportError while loading conftest
'/home/travis/build/diana-hep/pyhf/tests/conftest.py'.
tests/conftest.py:45: in <module>
(pyhf.tensor.pytorch_backend(), None),
pyhf/tensor/__init__.py:24: in __getattr__
e,
E pyhf.exceptions.ImportBackendError: ('There was a problem importing
PyTorch. The pytorch backend cannot be used.', ImportError('dlopen:
cannot load any more object with static TLS',))
TLS appears to stand for thead local storage
* https://stackoverflow.com/questions/19268293/matlab-error-cannot-open-with-static-tls
and seems to be a reoccuring issue with PyTorch. The advice for how to
deal with it from PyTorch Issue 2083 and 2575 seems to be to simply
change the import order so that
import torch
is always the first import in the files that are causing the issue. The
rational for this fix is not understood to me, other then it just makes
sure that libraries that (presumably) require a large amount of static
TLS are dealt with first.
matthewfeickert
force-pushed
the
fix/pytorch-static-TLS-load-error
branch
from
c3dd459
to
0bc1f64
Compare
|
We still need to understand why this is failing, don't we? Because of the change to how we run pytest isn't satisfactory... |
Yes, we need to understand what is going on in Issue #385. I made branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
masterafter PR Make extract_error compliant with uproot-methods v0.3.0 API #379 is accepted.v1.0release of PyTorch is causing issues with memory allocation in Travis resulting in errors or segfault 11.In requiring the latest version of PyTorch (v1.0) the loading of it after other imports in
tests/conftest.pycauses there to be an error during setup of the pytest fixturesTLS appears to stand for thread local storage
and seems to be a reoccurring issue with PyTorch. The advice for how to deal with it from PyTorch Issue 2083 and Issue 2575 seems to be to simply change the import order so that
import torchis always the first import in the files that are causing the issue. The rational for this fix is not understood to me, other then it just makes sure that libraries that (presumably) require a large amount of static TLS are dealt with first.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: