Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update nbformat to v4.4 for all tested notebooks #723

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jan 8, 2020

Description

Resolves #722

Thanks to @MSeal's very helpful advice (:bowing_man:) we learned that scrapbook requires a notebook with nbformat of v4.2 or higher. However, multiBinPois.ipynb had nbformat of v4.1. By opening the notebook in Jupyter Lab the format is automatically updated to have nbformat of v4.4, resolving the Issue.

To make sure this isn't a problem again, all the notebooks that are tested are opened in Jupyter Lab and then saved to make sure that they have nbformat of v4.4.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update all tested notebooks to have nbformat v4.4 to avoid errors

@matthewfeickert matthewfeickert added the fix A bug fix label Jan 8, 2020
@matthewfeickert matthewfeickert self-assigned this Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #723 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          52       52           
  Lines        2763     2763           
  Branches      392      392           
=======================================
  Hits         2621     2621           
  Misses         97       97           
  Partials       45       45
Flag Coverage Δ
#unittests 94.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a49f74...8d1ddac. Read the comment docs.

@matthewfeickert matthewfeickert changed the title fix: Update multiBinPois notebook nbformat to v4.4 fix: Update nbformat to v4.4 for all tested notebooks Jan 8, 2020
@lukasheinrich lukasheinrich merged commit f2646f3 into master Jan 8, 2020
@lukasheinrich lukasheinrich deleted the fix/update-nbformat-of-multiBinPois branch January 8, 2020 08:11
@kratsg
Copy link
Contributor

kratsg commented Jan 12, 2020

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Docs broken by nbformat update and scrapbook error
3 participants