fix: use ctx manager to ensure resources are freed #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
jpivarski
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
This looks like what was needed. Go ahead and merge it if you're done!
Ah, but first, we need to take care of the test failures. @douglasdavis described the fix: a module was moved inside dask_awkward. Let me see if there's another PR open with this, which we can merge in here.
|
It was this (from @douglasdavis on Slack):
I'll open a PR for just this, which we can merge against. @Moelf was also seeing this issue, so we need a separate commit that can be merged into all the open PRs. |
|
It's in #714. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long term I think we should be dealing with a per-process pool rather than a per-source pool, but that's a bigger task.
Fixes #712
@alexander-held would you be able to check that this works in your context w/o any changes to
HTTPSource.__del__?