Add type checks in constructors

[Saransh-cpp]

See #205

Added type checks in all the existing constructors.

[Saransh-cpp]

The type checks work but I am not sure if the implementation is clean enough (especially in the awkward constructors).

[jpivarski]

See below.

[Saransh-cpp]

Thank you for such detailed explanations, @jpivarski! It took me some time to go through all the details, but they were extremely helpful! The code snippets were also very helpful!

[Saransh-cpp]

The awkward constructors now look much better! The numpy type check still looks a bit messy as I encountered an edge case in the existing unit tests. Additionally, the type checks for numpy vectors is currently happening in the __array_finalise__ method but would it be better to perform the check in the __new__ method?

[Saransh-cpp]

Oh, the light package does not include awkward as its dependency. I think I should use numpy dtypes for numpy vectors.

[codecov-commenter]

Codecov Report

Merging #210 (2756495) into main (dfeead2) will increase coverage by 0.07%.
The diff coverage is 92.47%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   82.56%   82.63%   +0.07%     
==========================================
  Files          96       96              
  Lines       10475    10524      +49     
==========================================
+ Hits         8649     8697      +48     
- Misses       1826     1827       +1     

Impacted Files	Coverage Δ
src/vector/backends/_numba_object.py	69.17% <ø> (ø)
src/vector/backends/awkward.py	75.89% <33.33%> (ø)
src/vector/backends/awkward_constructors.py	47.34% <90.00%> (+4.56%)	⬆️
src/vector/backends/numpy.py	78.08% <94.73%> (+0.57%)	⬆️
src/vector/_compute/lorentz/beta.py	100.00% <100.00%> (ø)
src/vector/_compute/lorentz/gamma.py	100.00% <100.00%> (ø)
src/vector/_compute/lorentz/unit.py	100.00% <100.00%> (ø)
src/vector/_compute/planar/unit.py	100.00% <100.00%> (ø)
src/vector/_compute/spatial/costheta.py	100.00% <100.00%> (ø)
src/vector/_compute/spatial/cottheta.py	100.00% <100.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da67139...2756495. Read the comment docs.

[jpivarski]

There are still a few instances of expensive data conversions for the sake of checking a data type.

[Saransh-cpp]

Thank you for the review, @jpivarski! I have updated the PR with your suggestions! I have also updated the _is_type_safe function in backends/numpy.py to use the constructed vector. Now the function does not require converting a NumPy vector to a list and then to a NumPy array.

[jpivarski]

This does it! The type-checks are fully general (no missing cases that I can see) and only metadata are iterated over, so I don't see any potential performance issues.

I'd say go ahead and merge it.

[Saransh-cpp]

Thank you for the constructive reviews! Merging this!