Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git archive support #244

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

Saransh-cpp
Copy link
Member

Updates vector with the new versioning feature (or bug fix?) mentioned here - scikit-hep/scikit-hep.github.io#250

@codecov-commenter
Copy link

Codecov Report

Merging #244 (dc6ca50) into main (d4ad49e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files          96       96           
  Lines       10524    10524           
=======================================
  Hits         8697     8697           
  Misses       1827     1827           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 5796854 into scikit-hep:main Aug 18, 2022
@henryiii
Copy link
Member

I'd call it a feature. git archive (including the autogenerated ones from GitHub) will have this file rendered out so you can better track where it came from. And setuptools_scm 7+ will pick this up for the version, as well.

@Saransh-cpp Saransh-cpp deleted the git-archive branch August 19, 2022 10:05
@Saransh-cpp Saransh-cpp added this to the v0.9.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants