Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Python 3.11! #282

Merged
merged 2 commits into from
Oct 25, 2022
Merged

chore: use Python 3.11! #282

merged 2 commits into from
Oct 25, 2022

Conversation

Saransh-cpp
Copy link
Member

Description

I am hoping this will work.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission passes doctests? ($ xdoctest ./src/vector or $ nox -s doctests)

Before Merging

  • Summarize commit messages into a brief review of the Pull request.

@henryiii
Copy link
Member

It should, 3.11 for actions should have been released this morning. But we'll see! 🤞

@henryiii
Copy link
Member

henryiii commented Oct 25, 2022

We should add a "pass" check that depends on all the other ones, then only require that one. Then it's much easier to edit required checks for passing. See henryiii/scikit-build-core for an example.

@henryiii
Copy link
Member

I think this only worked because we don't have a macOS check - 3.11 macOS doesn't seem to be there yet. But doesn't affect us. :)

@Saransh-cpp Saransh-cpp changed the title Use Python 3.11! chore: use Python 3.11! Oct 25, 2022
@Saransh-cpp
Copy link
Member Author

I think this only worked because we don't have a macOS check - 3.11 macOS doesn't seem to be there yet. But doesn't affect us. :)

Nice!!

We should add a "pass" check that depends on all the other ones, then only require that one. Then it's much easier to edit required checks for passing. See henryiii/scikit-build-core for an example.

Added! I don't seem to have the appropriate rights for setting a job as "required". Jim did grant me the rights for accessing the settings tab of vector, but I cannot see any option to set (or un-set) a job as "required". Could you please make the required changes?

@Saransh-cpp Saransh-cpp added this to the v1.0.0 milestone Oct 25, 2022
@jpivarski
Copy link
Member

In settings, do you see the following?

image

That should take you to

image

"Edit" should go to

image

And then if you start typing in that box, you should get

image

@Saransh-cpp, your permissions level is "Maintain," and there is one higher, "Admin." If you can't do the above and need to, then that's how it can be fixed.

@Saransh-cpp
Copy link
Member Author

My settings page looks like this -

image

I am fine with being at the "Maintain" level. I don't think we would need any more "required" changes after this one (thanks to henry's suggestion!) 😅

Thank you for updating the requirements! Though as Henry suggested, it would be better to keep only the "pass" check as "required" to avoid updating these requirements every time a new job/workflow is added.

@Saransh-cpp Saransh-cpp merged commit 4fbbd81 into main Oct 25, 2022
@Saransh-cpp Saransh-cpp deleted the 3.11 branch October 25, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants