Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daisy example faulty output #1665

Closed
rougier opened this issue Aug 28, 2015 · 7 comments
Closed

Daisy example faulty output #1665

rougier opened this issue Aug 28, 2015 · 7 comments
Labels
⏩ type: Enhancement Improve existing features 📄 type: Documentation Updates, fixes and additions to documentation

Comments

@rougier
Copy link
Contributor

rougier commented Aug 28, 2015

If you look at the example in http://scikit-image.org/docs/dev/auto_examples/plot_daisy.html:

it seems some pixel are "missing". When you run the example localy, you don't have such problem but the overall quality of the circles and line is not so good I would say (circles appears very roughly antialiased).

@jni
Copy link
Member

jni commented Aug 28, 2015

@rougier I think this is an issue with Matplotlib, which resamples images when displaying. If you save the descs_img, do you see the same issue?

@rougier
Copy link
Contributor Author

rougier commented Aug 28, 2015

When I save the whole fig, the circles are ok (but still "badly" drawn).

@soupault
Copy link
Member

@tacaswell, could you comment on issue, please?

@soupault soupault added the 📄 type: Documentation Updates, fixes and additions to documentation label Dec 12, 2015
@tacaswell
Copy link
Contributor

Is there any way to visualize the daisies using circle and line objects?

I think the problem is that desc_img is an image full of one pixel wide features which is interacting badly with the aliasing when it is raterized on to the canvas.

On a phone so hard to dig much deeper.

@soupault soupault added the ⏩ type: Enhancement Improve existing features label Dec 12, 2015
@soupault
Copy link
Member

Yes, thanks.
I don't know if someone uses descs_img besides this example, but we can for sure re-implement it using matplotlib primitives.

stefanv added a commit to stefanv/scikit-image that referenced this issue Dec 14, 2015
@stefanv
Copy link
Member

stefanv commented Dec 14, 2015

How about some anti-aliased drawing? See #1827!

@soupault
Copy link
Member

Looks better I guess:
screenshot from 2015-12-14 23-19-18

@stefanv stefanv mentioned this issue Dec 14, 2015
@jni jni closed this as completed in 7313567 Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏩ type: Enhancement Improve existing features 📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants