Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy to >= 1.16 #4259

Closed
sciunto opened this issue Oct 19, 2019 · 7 comments
Closed

Bump numpy to >= 1.16 #4259

sciunto opened this issue Oct 19, 2019 · 7 comments
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Milestone

Comments

@sciunto
Copy link
Member

sciunto commented Oct 19, 2019

Description

In the TODO list, several tasks are about numpy >= 1.16. This version opens up the possibility to use linspace, logspace... functions in nD. As it is a goal to get nD algorithm in scikit-image, I propose to bump numpy for our next release to facilitate future contributions.

I assign this task to myself.

@sciunto sciunto added the 🔧 type: Maintenance Refactoring and maintenance of internals label Oct 19, 2019
@sciunto sciunto added this to the 0.17 milestone Oct 19, 2019
@sciunto sciunto self-assigned this Oct 19, 2019
@hmaarrfk
Copy link
Member

I love bleeding edge as much as the next person, but how does this affect things for popular distros? Would they be stuck on older versions of skimage due to this?

For example, I think ubuntu 19.10 is packaging Numpy 1.16.2 and skimage 0.14.2 for python3.

@sciunto
Copy link
Member Author

sciunto commented Oct 19, 2019

1.16.x has been published in Jan. 2019. If we take 6 months to prepare the next release, the min req. version will be out for more than a year.

@hmaarrfk
Copy link
Member

Right, that makes sense. But I'm more of the opinion that we should try to have more rolling release ;)

@jni
Copy link
Member

jni commented Oct 21, 2019

@sciunto how does this fit in with the NEP-29 deprecation policy? Is it more aggressive or basically implementing the policy?

@sciunto
Copy link
Member Author

sciunto commented Oct 21, 2019

It depends when we release the next version, 1.15 is supposed to be unsupported in Jul 23, 2020. It doesn't look so aggressive.

@sciunto sciunto mentioned this issue Dec 12, 2019
9 tasks
@sciunto sciunto removed their assignment Dec 13, 2019
@hmaarrfk
Copy link
Member

It seems a little aggressive for me:

Using: numpy/numpy#15173 https://gist.github.com/hmaarrfk/0e2a01d57f07f55eb99d177da92691b6

I found that bumping to 1.16, even if we are to release in June 2020, would mean that we are only supporting versions in the last 18 months:
image

@grlee77
Copy link
Contributor

grlee77 commented Apr 5, 2021

NumPy was bumped to 1.16.5 in #5016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

4 participants