-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump numpy versions to match scipy (kinda) #5016
Conversation
8a5dcea
to
8d8ef7a
Compare
@hmaarrfk coolio, let us know when this is ready for review/merge. |
8d8ef7a
to
be6d70d
Compare
rgrommers replied and indicated that the current difference between AIX and non AIX might have been an oversight. This is ready now. |
Travis disagrees. 😂 But actually I don't think it's your fault, I think plotly isn't happy with minimum requirements. @emmanuelle the error is: File "doc/examples/segmentation/plot_regionprops.py", line 98, in <module>
fig = px.imshow(img, binary_string=True)
TypeError: imshow() got an unexpected keyword argument 'binary_string' I think this feature was only added in the most recent version of plotly, right? Do we need to update our minimum plotly version requirement in the docs requirements? The other error is also in the docs, a failed download from pivchallenge.org, so I'm approving this. |
The CIs have been really problematic. I thought I had fixed them yesterday with an other PR. |
Pyproject toml specifies build time dependencies for those building from source using pip tools. Users on the platforms we support will never interact with this. However, some users of pip on exotic platforms have asked for it to be kept up to date,and we have obliged. |
Yeah, let's turn them off, seemed like a good idea at the time but they're just annoying. 🤣 More seriously, I'm happy to merge this as is, or do you want to rebase on master now that #5021 is in? |
@jni in some projects on Github there is an "update branch" button which allows to merge master to the PR branch, and it's very convenient. Maybe it's available only for branches of the same repo and not on a fork? I don't really understand which repos / PRs have this button. |
be6d70d
to
7364ff2
Compare
Thanks @hmaarrfk merging! |
Description
I'm waiting to hear back on the reasons why scipy held back bumping AIX numpy requirements.
scipy/scipy#12940
Hopefully this should help with the failures on the minimum version requirement.
Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.