Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orphaned codecov files #5331

Open
grlee77 opened this issue Apr 15, 2021 · 2 comments
Open

orphaned codecov files #5331

grlee77 opened this issue Apr 15, 2021 · 2 comments
Labels
🐛 Bug 🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@grlee77
Copy link
Contributor

grlee77 commented Apr 15, 2021

Description

We used to run codecov via TravisCI, but I don't think we have run it since we moved to GitHub actions. I was looking into this due to a recent security incident. As far as I can tell, we should be unaffected here because I don't think we have run codecov after Jan 31st, 2021 when the issue first occured.

Which of the following actions should we take?:
1.) remove the unused .codecov.yml as well as mention of codecov in requirements files and contributor docs
2.) update our CI scripts to enable codecov again

If option 1, is there another coverage tool we should consider?

@grlee77 grlee77 added 🔧 type: Maintenance Refactoring and maintenance of internals 🤖 type: Infrastructure CI, packaging, tools and automation labels Apr 15, 2021
@hmaarrfk
Copy link
Member

ohhhh, that is why codecov bot hasn't been working.

I think adding code coverage again would be good. I would prefer it if the bot didn't speak though.

@mkcor
Copy link
Member

mkcor commented Apr 16, 2021

Could we do option 1 and include the same kind of code coverage as for local testing in our CI scripts?

  • Update contribution guidelines about using TravisCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug 🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

6 participants