Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the meaning of the weights term for TV denoising functions #5379

Closed
grlee77 opened this issue May 5, 2021 · 2 comments · Fixed by #6544
Closed

clarify the meaning of the weights term for TV denoising functions #5379

grlee77 opened this issue May 5, 2021 · 2 comments · Fixed by #6544
Assignees
Labels
📄 type: Documentation Updates, fixes and additions to documentation

Comments

@grlee77
Copy link
Contributor

grlee77 commented May 5, 2021

Description

In the Zulip chat, there was a question regarding the "weight" term in denoise_tv_bregman.

In that implementation, smaller weights lead to more smoothing whereas the opposite is true for denoise_tv_chambolle.

The underlying cause seems just to be which term in the cost function the weight applies to (i.e. either the data-consistency or the TV regularization term). We should update the docstrings to clarify where the weight is being applied to make its function less opaque.

@grlee77 grlee77 added the 📄 type: Documentation Updates, fixes and additions to documentation label May 5, 2021
@gmelon
Copy link
Contributor

gmelon commented Dec 10, 2021

Is this issue still valid? If so, I would like to revise it.

@rfezzani
Copy link
Member

Any PR is welcome 😉. Thank you @gmelon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
4 participants