Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels should be uploaded before sdist in release process #5448

Closed
jni opened this issue Jun 29, 2021 · 0 comments
Closed

Wheels should be uploaded before sdist in release process #5448

jni opened this issue Jun 29, 2021 · 0 comments
Labels
🔰 Good first issue 🤖 type: Infrastructure CI, packaging, tools and automation

Comments

@jni
Copy link
Member

jni commented Jun 29, 2021

Description

Missed this in reviewing #5397. We prefer to release wheels before source because otherwise there is a small window during which users who pip install scikit-image will require compilation. In general this will be very small but in fact it could be big if e.g. there is a network failure in the VM during release.

The relevant lines are here:

twine upload ${{ github.workspace }}/dist/scikit-image-${SK_VERSION:1}.tar.gz
cd ${{ github.workspace }}/dist
twine upload *.whl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 Good first issue 🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

No branches or pull requests

2 participants