Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5448 : Release wheels before source #5469

Merged
merged 2 commits into from
Jul 12, 2021
Merged

fix #5448 : Release wheels before source #5469

merged 2 commits into from
Jul 12, 2021

Conversation

lilisako
Copy link
Contributor

Description

As mentioned in #5448, release wheels before source.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

Copy link
Member

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs a little comment for the design desicion.

@hmaarrfk
Copy link
Member

Thanks @lilisako

@hmaarrfk
Copy link
Member

I took the liberty to push the comment I suggested. I always have mixed feelings about pushing to contributor's PRs but for this small comment I felt it was appropriate.

I hope you don't take any offense!

I can merge when the new tests pass.

@hmaarrfk
Copy link
Member

even if the failure is real. it is definitely unrelated.

I'm going to merge as is.

@hmaarrfk hmaarrfk merged commit 6ff11f6 into scikit-image:main Jul 12, 2021
@hmaarrfk
Copy link
Member

Thanks!!

@lilisako
Copy link
Contributor Author

@hmaarrfk

I took the liberty to push the comment I suggested. I always have mixed feelings about pushing to contributor's PRs but for this small comment I felt it was appropriate.
I hope you don't take any offense!

Not at all! I appreciate your prompt review and thanks for merging this PR!
Best regards,
Risako🌸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants