Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otsu thresholding admits hist as input parameter on v0.19.0 while multi-Otsu does not #5541

Closed
andres-fr opened this issue Aug 26, 2021 · 0 comments · Fixed by #5543
Closed

Comments

@andres-fr
Copy link
Contributor

Description

As it can be seen in the API docs for version 0.19.0.dev0, multi-Otsu still has the older signature, while 2-class Otsu has the newer one:

https://scikit-image.org/docs/dev/api/skimage.filters.html#skimage.filters.threshold_otsu
https://scikit-image.org/docs/dev/api/skimage.filters.html#skimage.filters.threshold_multiotsu

Feeding the histogram directly has many advantageous use cases, one of them is extracting thresholds for multiple images at the same time (e.g. for video sequences). The feature requested here is to update the signature for multi-Otsu to accept histograms as well.

Currently there is another PR open on multi-Otsu, awaiting integration: #5198

I've proposed a workaround there and the author proposed to submit a new, separate PR.
I've opened this issue to introduce and sustain the new PR that I hope to submit in the following days.

Way to reproduce

This issue is about interfaces and doesn't involve any particular implementation.

Version information

As mentioned above, the signature inconsistency happens at least in skimage version 0.19.0.dev0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants