Line length in PR is currently not checked?

[lagru]

Our ruff configuration specifies

scikit-image/pyproject.toml

Line 156 in c2e2c22

line-length = 88

but then ignores line-length explicitly in

scikit-image/pyproject.toml

Lines 164 to 165 in c2e2c22

	ignore = [
	'E501',

Since PR linting with pep8speaks was recently disabled in favor of pre-commit.ci, line length is currently not checked at all in PRs. Do we care?

This seems like an oversight to me and I would have simply made a PR to remove the ignored rule. However, ruff runs on the complete file and not on the diff. This is a problem because I don't want to force contributors to reformat code they haven't touched.

There might be ways to achieve this feature (see astral-sh/ruff#4049 (comment) or https://github.com/dorschw/riff) but they don't look ideal.

I am not sure if I dare suggest this, but we could also re-enable pep8speaks as it supports this use case with its default diff_only: True option.

... or we revive a slightly Sisyphean discussion around introducing a code formatter like black. 😅 This would be my long-term preference.

[lagru]

Noticed this in #7192.

[mkcor]

This is a problem because I don't want to force contributors to reformat code they haven't touched.

Absolutely.

I am not sure if I dare suggest this, but we could also re-enable pep8speaks as it supports this use case with its default diff_only: True option.

I'm not opposed.