Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose dtypes from fused_numerics.pxd for test suite #7268

Open
2 tasks
lagru opened this issue Dec 15, 2023 · 1 comment
Open
2 tasks

Expose dtypes from fused_numerics.pxd for test suite #7268

lagru opened this issue Dec 15, 2023 · 1 comment
Labels
🔰 Good first issue 🙏 Feature request 😴 Dormant no recent activity 🔧 type: Maintenance Refactoring and maintenance of internals

Comments

@lagru
Copy link
Member

lagru commented Dec 15, 2023

Description:

We have a nice collection of fused numeric types in fused_numerics.pxd.

  • It would be nice to have corresponding lists of these fused types available at runtime from Python. That way we can easily slap the appropriate @pytest.mark.parametrize("dtype", _dtypes_uint) on a test instead of listing each dtype by hand again and again. Could go into _shared.testing in my opinion.
  • Check that we used these consistently instead of creating a new local fused type each time. Looking at you _extrema_cy.pyx.
Copy link

Hello scikit-image core devs! There hasn't been any activity on this issue for more than 180 days. I have marked it as "dormant" to make it easy to find.
To our contributors, thank you for your contribution and apologies if this issue fell through the cracks! Hopefully this ping will help bring some fresh attention to the issue. If you need help, you can always reach out on our forum
If you think that this issue is no longer relevant, you may close it, or we may do it at some point (either way, it will be done manually).

@github-actions github-actions bot added the 😴 Dormant no recent activity label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔰 Good first issue 🙏 Feature request 😴 Dormant no recent activity 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Development

No branches or pull requests

1 participant