Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions to skimage.restoration #855

Closed
ahojnnes opened this issue Dec 14, 2013 · 20 comments
Closed

Move functions to skimage.restoration #855

ahojnnes opened this issue Dec 14, 2013 · 20 comments
Milestone

Comments

@ahojnnes
Copy link
Member

Move: skimage.filter.denoise_*, skimage.measure.unwrap_phase to the new restoration module.

@stefanv
Copy link
Member

stefanv commented Feb 5, 2014

@ahojnnes Is this for the next release?

@ahojnnes
Copy link
Member Author

ahojnnes commented Feb 5, 2014

Not sure what you mean by "next", but I meant 0.10.

@stefanv
Copy link
Member

stefanv commented Feb 5, 2014

I just meant, can we go ahead and do it--sounds like yes?

@ahojnnes
Copy link
Member Author

ahojnnes commented Feb 5, 2014

Yes :-)

On Wed, Feb 5, 2014 at 10:32 AM, Stefan van der Walt <
notifications@github.com> wrote:

I just meant, can we go ahead and do it--sounds like yes?

Reply to this email directly or view it on GitHubhttps://github.com//issues/855#issuecomment-34189666
.

@stefanv
Copy link
Member

stefanv commented Feb 5, 2014

OK, you or me, or shall we use
http://www.random.org/integers/?num=1&min=1&max=100&col=5&base=10&format=plain&rnd=new ?

If so, I pick "heads" (i.e., the interval between 0 and 50). If the number falls in that interval, it's my job :)

@ahojnnes
Copy link
Member Author

ahojnnes commented Feb 5, 2014

Maybe we should wait until unwrap_phase is actually fixed... ?

@stefanv
Copy link
Member

stefanv commented Feb 5, 2014

That's a very good point.

@ahojnnes
Copy link
Member Author

See #924.

@aeberspaecher
Copy link

Please note unwrap_phase() is still documented to be part of the exposure module, cmp. http://scikit-image.org/docs/dev/api/api.html and http://scikit-image.org/docs/dev/auto_examples/plot_phase_unwrap.html.

@JDWarner
Copy link
Contributor

I just checked and the documentation is now updated in the relevant files.
It just hasn't been regenerated & pushed to the site yet.

On Fri, Apr 18, 2014 at 11:31 AM, Alexander Eberspächer <
notifications@github.com> wrote:

Please note unwrap_phase() is still documented to be part of the exposure
module, cmp. http://scikit-image.org/docs/dev/api/api.html and
http://scikit-image.org/docs/dev/auto_examples/plot_phase_unwrap.html.


Reply to this email directly or view it on GitHubhttps://github.com//issues/855#issuecomment-40822316
.

@stefanv
Copy link
Member

stefanv commented Apr 18, 2014

​We really should get the docs automatically pushed upon every commit to
master. Volunteers? I can tell you how!

@jni
Copy link
Member

jni commented Apr 18, 2014

@stefanv if you give me some pointers, I'd be happy to set this up — I've been wanting to get more familiar with the doc build process so this is a good excuse. But caveat — won't be able to touch this till Monday (Europe time).

@stefanv
Copy link
Member

stefanv commented Apr 18, 2014

Okay, I'll ping you on Monday.

@JDWarner
Copy link
Contributor

If you don't mind copying me, I'd love to know how this is done (or could just inspect the PR from @jni )

@stefanv
Copy link
Member

stefanv commented Apr 18, 2014

@stefanv
Copy link
Member

stefanv commented Apr 18, 2014

@stefanv
Copy link
Member

stefanv commented Apr 23, 2014

/ping @jni

@jni
Copy link
Member

jni commented Apr 23, 2014

Hey @stefanv, I didn't get very far on Monday due to lack of internet connectivity, which I'd thought would be better. (I'm traveling.) Next few days are going to be busy so won't get this working till next week... If someone wants to pick up the torch that's fine obviously...! (@JDWarner, @sharky93?)

@stefanv
Copy link
Member

stefanv commented Apr 27, 2014

/ping @sharky93 -- did you get this working?

@sharky93
Copy link
Member

Yeah, its working. I've to get done with some finishing, intermediate results of a push can be seen here @ https://github.com/sharky93/docs/tree/gh-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants