New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Sphinx 1.3 API change #1424
Handle Sphinx 1.3 API change #1424
Conversation
@blink1073 when and if this passes and gets merged (=P), I'll rebase... I like to keep PRs small and self-contained... |
Why sphinx why?!?!? |
mpl is also having issues. We have pinned to 1.2.3 for now... |
@scikit-image/core, someone please merge this as it is holding up all open PRs. |
Travis is happy, AppVeyor is still queued 4 hours later. I realize it's a free service and resources are limited, but that kind of delay is borderline unusable. Thanks for the fix @blink1073 - I'm merging this. If Windows ends up having a problem we can deal with that separately. |
FIX: Handle Sphinx 1.3 API change
Sphinx changed
cfg.source_suffix
to be a list in version 1.3.We were using it as a string.
First, I tried just changing
cfg.source_suffix
to a string if it was a list, but that affected other parts of the build. Instead, we create a newcfg.source_suffix_str
and use that, so we can support all versions of Sphinx.