-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watershed fixes for issue #803 #1530
Conversation
@blink1073 @arve0 we are now seeing this NumPy compilation failure on AppVeyor across several recent builds - e.g., here (#1530) and in #1483. At first I figured it was an intermittent issue, but it's looking more generalized. If #1526 contains a solution, we should make squashing the last 2.7 bug and merging it a priority as this issue is holding up other PRs. |
Not sure these errors are related to #1526, but adding windows wheels to a binstar channel (as mentioned by @jjhelmus) will most likely stabilize windows builds. As of now, #1526 does not hold a complete solution, and I do not have time to finish it. So if its a pressing issue someone should pick it up. |
Hi @LeeKamentsky, could you rebase on master? There shouldn't be any conflicts, but the AppVeyor build is now fixed. Once we get the Windows green light we can merge this. |
Lovely, AppVeyor times out on Restart this one when you get the chance, @stefanv - I do not have the option on AppVeyor. |
Brilliant. Thank you again @kevin-keraudren and @LeeKamentsky for this fix and bonus enhancement! =) |
Watershed fixes for issue #803 (incorrect propagation in plateaus)
This adds an ordering of the structuring elements that favors horizontal and vertical structuring elements over diagonal ones. I'd like this addition to be the fix for issue #803. The pull request was done on top of @kevin-keraudren's pull request #1520.