Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watershed fixes for issue #803 #1530

Merged
merged 2 commits into from
May 29, 2015
Merged

Watershed fixes for issue #803 #1530

merged 2 commits into from
May 29, 2015

Conversation

LeeKamentsky
Copy link

This adds an ordering of the structuring elements that favors horizontal and vertical structuring elements over diagonal ones. I'd like this addition to be the fix for issue #803. The pull request was done on top of @kevin-keraudren's pull request #1520.

@JDWarner
Copy link
Contributor

@blink1073 @arve0 we are now seeing this NumPy compilation failure on AppVeyor across several recent builds - e.g., here (#1530) and in #1483. At first I figured it was an intermittent issue, but it's looking more generalized.

If #1526 contains a solution, we should make squashing the last 2.7 bug and merging it a priority as this issue is holding up other PRs.

@arve0
Copy link
Contributor

arve0 commented May 26, 2015

Not sure these errors are related to #1526, but adding windows wheels to a binstar channel (as mentioned by @jjhelmus) will most likely stabilize windows builds.

As of now, #1526 does not hold a complete solution, and I do not have time to finish it. So if its a pressing issue someone should pick it up.

@JDWarner
Copy link
Contributor

@arve0 I think #1526 may have a solution, intended or accidental, for AppVeyor. I'm talking specifically about AppVeyor - I've seen this error in two PRs this weekend, but your last commit into #1526 built successfully on AppVeyor.

@JDWarner
Copy link
Contributor

Hi @LeeKamentsky, could you rebase on master? There shouldn't be any conflicts, but the AppVeyor build is now fixed. Once we get the Windows green light we can merge this.

@JDWarner
Copy link
Contributor

Lovely, AppVeyor times out on git clone.

Restart this one when you get the chance, @stefanv - I do not have the option on AppVeyor.

@jni
Copy link
Member

jni commented May 29, 2015

Brilliant. Thank you again @kevin-keraudren and @LeeKamentsky for this fix and bonus enhancement! =)

jni added a commit that referenced this pull request May 29, 2015
Watershed fixes for issue #803 (incorrect propagation in plateaus)
@jni jni merged commit e497e5c into scikit-image:master May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants