Mimic the way scipy handles numpy in setup.py #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| URL = 'http://scikit-image.org' | ||
| LICENSE = 'Modified BSD' | ||
| DOWNLOAD_URL = 'http://github.com/scikit-image/scikit-image' | ||
| DISTNAME = 'scikit-image' |
There was a problem hiding this comment.
Sorry, autopep8 got me here
| pass | ||
| else: | ||
| print('To install scikit-image from source, you will need numpy.\n' + | ||
| 'Install numpy with pip:\n' + |
There was a problem hiding this comment.
Implicit string concatenation - no pluses needed!
I'd consider doubling the newlines on either side of the actual pip call.
stefanv
added a commit
that referenced
this pull request
Jul 13, 2015
Mimic the way scipy handles numpy in setup.py
|
Sorry, @JDWarner, saw your comment now only--we can fix that in another commit, if you want. |
|
I'll fix @JDWarner's comment in a new PR, and I think we should exclude |
|
And also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scipy has this figured out, let's just do what they do:
https://github.com/scipy/scipy/blob/master/setup.py