-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some remaining TODO items #1936
Conversation
@ahojnnes Thanks! Some nice API cleanups coming good! =) |
@jni What happened to the 2x 👍 policy :) |
@stefanv This was bugging me too ! If a core team member has sent a PR, that means he's already +1 to it. So, the next core dev is the second thumbs up guy. But, I guess you are eliminating the PR author from the right to give thumbs up. ;) |
@OrkoHunter Yes, in this case the PR is pretty straightforward and I was just teasing Juan, but I think the second assessment of "at least two reviewers" is what we'll be going for. |
@stefanv slipped my mind! I agree that I should have just 👍d it. I wish github offered real support for such policies... |
@Carreau and @matthew-brett are interested in extending Homu to support just this kind of thing. |
For the +1s, can't someone create a website that will offer +1 badges ? Edit : What I mean is the PR creator embeds a SVG image in their PR description which shows the number of +1s received. On clicking on that image, users a re redirect to a website where they can sign in and either upvote or downvote an issue |
Install https://www.zenhub.io/ extension, and you get a +1 button people can click that show the count.
Yes, if you fork Homu, I'm interested, in particular the jupyter team have some local scrip to backport a PR from one branch to another and migrate issues from one repo to another. I'd like to be able to |
No description provided.