Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some remaining TODO items #1936

Merged
merged 3 commits into from
Feb 9, 2016
Merged

Fix some remaining TODO items #1936

merged 3 commits into from
Feb 9, 2016

Conversation

ahojnnes
Copy link
Member

@ahojnnes ahojnnes commented Feb 9, 2016

No description provided.

@jni
Copy link
Member

jni commented Feb 9, 2016

@ahojnnes Thanks! Some nice API cleanups coming good! =)

jni added a commit that referenced this pull request Feb 9, 2016
Fix some remaining TODO items
@jni jni merged commit a6e0761 into scikit-image:master Feb 9, 2016
@stefanv
Copy link
Member

stefanv commented Feb 9, 2016

@jni What happened to the 2x 👍 policy :)

@OrkoHunter
Copy link
Contributor

@stefanv This was bugging me too ! If a core team member has sent a PR, that means he's already +1 to it. So, the next core dev is the second thumbs up guy. But, I guess you are eliminating the PR author from the right to give thumbs up. ;)

@stefanv
Copy link
Member

stefanv commented Feb 9, 2016

@OrkoHunter Yes, in this case the PR is pretty straightforward and I was just teasing Juan, but I think the second assessment of "at least two reviewers" is what we'll be going for.

@jni
Copy link
Member

jni commented Feb 9, 2016

@stefanv slipped my mind! I agree that I should have just 👍d it. I wish github offered real support for such policies...

@stefanv
Copy link
Member

stefanv commented Feb 9, 2016

👍 And... https://github.com/dear-github/dear-github

@stefanv
Copy link
Member

stefanv commented Feb 9, 2016

@Carreau and @matthew-brett are interested in extending Homu to support just this kind of thing.

@vighneshbirodkar
Copy link
Contributor

For the +1s, can't someone create a website that will offer +1 badges ?

Edit : What I mean is the PR creator embeds a SVG image in their PR description which shows the number of +1s received. On clicking on that image, users a re redirect to a website where they can sign in and either upvote or downvote an issue

@Carreau
Copy link
Contributor

Carreau commented Feb 9, 2016

For the +1s, can't someone create a website that will offer +1 badges ?

Install https://www.zenhub.io/ extension, and you get a +1 button people can click that show the count.

@Carreau and @matthew-brett are interested in extending Homu to support just this kind of thing.

Yes, if you fork Homu, I'm interested, in particular the jupyter team have some local scrip to backport a PR from one branch to another and migrate issues from one repo to another.

I'd like to be able to @homu migrate-to foo/bar, or @homu backport-to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants