Have detect/extract/detect_and_extract methods return underlying object #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupault
changed the title
Borda
suggested changes
Jul 13, 2019
| @@ -182,3 +184,5 @@ def extract(self, image, keypoints): | |||
|
|
|||
| _brief_loop(image, self.descriptors.view(np.uint8), keypoints, | |||
| pos1, pos2) | |||
|
|
|||
| return self | |||
There was a problem hiding this comment.
missing Return in docs... also shall we return itself of just self.descriptors?
| @@ -206,6 +208,8 @@ def detect(self, image): | |||
| self.scales = scales[best_indices] | |||
| self.orientations = orientations[best_indices] | |||
| self.responses = responses[best_indices] | |||
|
|
|||
| return self | |||
| @@ -272,6 +276,8 @@ def extract(self, image, keypoints, scales, orientations): | |||
|
|
|||
| self.descriptors = np.vstack(descriptors_list).view(np.bool) | |||
| self.mask_ = np.hstack(mask_list) | |||
|
|
|||
| return self | |||
| @@ -338,3 +344,5 @@ def detect_and_extract(self, image): | |||
| self.orientations = orientations[best_indices] | |||
| self.responses = responses[best_indices] | |||
| self.descriptors = descriptors[best_indices] | |||
|
|
|||
| return self | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #1962
This is the most straightforward solution where I've simply added return self to the end of the appropriate functions. However, I believe as @vighneshbirodkar alluded to in the issue thread there may be a better solution where instead the FeatureDetector and DescriptorExtractor base classes are modified to return the underlying object instead. In this case, these methods would call something like self._detect and self._extract (and throwing not implemented exceptions there if necessary) before returning self. However, as is the FeatureDetector and DesciptorExtract base classes don't really do anything besides throw not implemented exceptions so it wasn't clear that the refactoring would be worth it.