Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fused type warping #1977

Closed
wants to merge 2 commits into from
Closed

Added fused type warping #1977

wants to merge 2 commits into from

Conversation

akuchibotla
Copy link

Starting a PR for discussion on #1287

Added a fused type and modified a few arguments but I have a few questions:

  1. What data types should we be including into the fused type?
  2. What arguments can safely be converted into the fused type?
  3. Where exactly is the casting to double happening to begin with?

@sciunto
Copy link
Member

sciunto commented Aug 27, 2016

@ahojnnes Would you like to review this? You opened the ticket.

jni
jni reviewed Oct 21, 2016
View reviewed changes
skimage/transform/_warps_cy.pyx
cnp.float64_t
cnp.uint64_t
cython.float
cython.double
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akuchibotla sorry for the long delay in response... Anyway, why not just use cython.numeric here?

@jni jni mentioned this pull request Oct 19, 2018
Merged
9 tasks
@soupault
Copy link
Member

Superseded by #3486

@soupault soupault closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akuchibotla @sciunto @soupault @jni