Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.0 release #1984

Merged
merged 2 commits into from
Mar 7, 2016
Merged

0.12.0 release #1984

merged 2 commits into from
Mar 7, 2016

Conversation

emmanuelle
Copy link
Member

I tagged 0.12! docs have already been built.

Should this PR be merged or should I just push to origin?

@emmanuelle
Copy link
Member Author

I can't see the new tag in the "files changed" tab... Maybe it's because it's not a file, but I wonder if the tag will be included in the merge...

@stefanv
Copy link
Member

stefanv commented Mar 5, 2016 via email

@emmanuelle
Copy link
Member Author

I did push --tags. More precisely, I did
git push --tags emma 0.12.x
with emma being my github repo.

I can see the tag on my repo https://github.com/emmanuelle/scikits.image/releases

Anything else that I should do?

@emmanuelle
Copy link
Member Author

I could also have pushed directly to origin master, instead of pushing to my github. Is this how you would do @stefanv ?

If pushing to scikit-image is the right way to go, i ll do it tomorrow and close this PR.

Sorry for the baby steps, let s say that I feel a bit shy about pushing directly to scikit-image

@emmanuelle
Copy link
Member Author

I also pushed the 0.12.x to scikit-image/scikit-image, as advised by @jni on gitter. This PR could therefore be closed, but I wonder at which point the commits will be merged?

@stefanv stefanv merged commit 50fa219 into scikit-image:master Mar 7, 2016
@stefanv
Copy link
Member

stefanv commented Mar 7, 2016

Thanks, @emmanuelle for all your hard work, and @jni for providing a helping hand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants