Remove lena image from test suite #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref #1865 |
Results from the morphology module were compared against output from the corresponding MATLAB functions, as applied to the lena test image. This image does not conform to the Debian Free Software Guidelines and had to be removed. The output is now tested against results generated with the current version of scikit-image (0.12.0), which is known to be correct due to the comparison described above.
|
Looks good to me! Regarding the errors:
Extra finding:
|
|
Thanks for the review, Egor. I've made the necessary updates.
|
|
LGTM, merging. |
JDWarner
added a commit
that referenced
this pull request
Mar 7, 2016
Remove lena image from test suite
|
And Lena is finally gone! |
|
Right before IWD 😬 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results from the morphology module were compared against output from the
corresponding MATLAB functions, as applied to the lena test image. This image
does not conform to the Debian Free Software Guidelines and had to be removed.
The output is now tested against results generated with the current version of
scikit-image (0.12.0), which is known to be correct due to the comparison
described above.