Gabor aspect ratio #2049
Open
Gabor aspect ratio #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is the spatial aspect ratio, and specifies the ellipticity of the support of the Gabor function.
This parameter is the spatial aspect ratio, and specifies the ellipticity of the support of the Gabor function.
This parameter is the spatial aspect ratio, and specifies the ellipticity of the support of the Gabor function. And add a example at ./doc/examples/filters
This parameter is the spatial aspect ratio, and specifies the ellipticity of the support of the Gabor function. And add an example at ./doc/examples/filters
Aspect ratio is the spatial aspect ratio, and specifies the ellipticity of the support of the Gabor function.
soupault
added
⏩ type: Enhancement
skimage/filters/_gabor.py
Outdated
| @@ -14,7 +14,7 @@ def _sigma_prefactor(bandwidth): | |||
|
|
|||
|
|
|||
| def gabor_kernel(frequency, theta=0, bandwidth=1, sigma_x=None, sigma_y=None, | |||
| n_stds=3, offset=0): | |||
| n_stds=3, offset=0, aspectratio=1): | |||
|
Thanks for your contribution. This needs a unit test with an aspect ratio of != 1 |
|
@wwjd228 Did you have a chance to look at it? The modifications required are minor :) |
Rename the parameter "aspectratio" to "aspect_ratio".
|
Sorry, I don't know how to create a unit test with an aspect ratio of != 1. |
Current coverage is 90.71% (diff: 100%)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Tell us about your new feature, improvement, or fix! If relevant, please supplement the PR with images.]
I add a new parameter about aspect ratio in function gabor_kernel.
Checklist
[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]
./doc/examples(new features only)[For detailed information on these and other aspects see scikit-image contribution guidelines]
References
[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]