Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOG: ensure visualisation is in dtype_limits + maint. #2261

Closed
wants to merge 6 commits into from

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Aug 27, 2016

This PR partially fixes #1334.

  • if visualise is True, ensure that the output is in [0, 1]. -> bugfix.
  • clean up inline comments
  • retrospective note added about that deprecation (was not in api_changes)
  • remove option that is deprecated since 0.11 (was not in TODO list)
  • fix docstring (references)

@sciunto sciunto added bug 🔧 type: Maintenance Refactoring and maintenance of internals 🧐 Needs review labels Aug 27, 2016
@sciunto sciunto changed the title Hog: ensure visualisation in dtype_limits + maintainance. Hog: ensure visualisation in dtype_limits + maint. Aug 27, 2016
@sciunto sciunto changed the title Hog: ensure visualisation in dtype_limits + maint. HOG: ensure visualisation is in dtype_limits + maint. Aug 27, 2016
@codecov-io
Copy link

codecov-io commented Aug 27, 2016

Current coverage is 90.75% (diff: 100%)

No coverage report found for master at 74c6b8d.

Powered by Codecov. Last update 74c6b8d...8a1f858

@sciunto sciunto added this to the 0.13 milestone Sep 18, 2016
@sciunto
Copy link
Member Author

sciunto commented Sep 18, 2016

@scikit-image/core Who wants to take the lead for the review? To me, it's ready.

@stefanv
Copy link
Member

stefanv commented Sep 21, 2016

Let's get #2040 out the door before merging this one.

@sciunto sciunto closed this Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 Needs review 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
Development

Successfully merging this pull request may close these issues.

Chaining multiple skimage functions leads to conversion issues
4 participants