WIP: Multidimensional structure tensor #2489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n computing the BRIEF descriptors for normal and uniform mode
jni
reviewed
Feb 5, 2017
| out = () | ||
| derivatives = list(_compute_derivatives(image, mode=mode, cval=cval)) | ||
| for i in range(len(derivatives)): | ||
| for j in range(len(derivatives)): |
There was a problem hiding this comment.
You can just use range(i, len(derivatives)) here and avoid the if statement on the next line. =)
jni
reviewed
Feb 5, 2017
There was a problem hiding this comment.
@tseclaudia I know this is a WIP but thought I would comment anyway:
- don't comment out old code, just delete it. That's what git is for. =)
- We probably want to use the "natural" order (
ndi.sobel(..., axis=i) for i in range(image.ndim)) and reverse it only for 2D for backwards compatibility. See Update hessian matrix code to include order kwarg #2327 for an example.
Thanks for this!
3 tasks
|
It looks like this PR hasn't been active in a long time, plus #5002 superseded it. If there is no objection, I will close this PR [edit: |
|
Closing as per #2489 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2346.